Review of "Water Panel" version 12

Details Page Preview

Turns your taskbar into a liquid audio visualizer. The water rises and ripples with whatever is playing, and takes its colours from your wallpaper. Works with Zorin Taskbar or Dash to Panel. Fetelabs Task Bar already has Water Panel built in, so with it you don't need this; if both are on, this one steps aside. While Spotify plays, the Fetelabs wordmark shows through the water whenever a wave hits it: a word of your own (JOLA by default), the live Fetelabs test tube and FETELABS, with glossy paint drips that fill with the music and fall into the water (can be turned off). Needs python3 with NumPy and parec (pulseaudio-utils, also works on PipeWire) for the audio analysis. On Debian/Ubuntu/Zorin: sudo apt install python3-numpy pulseaudio-utils By Fetelabs: fetelabs.ai · X @mostlyjola · Instagram @fetelabs Tips: USDC on Solana ONLY to Dox9t9toz7BwwHJaqqsTpt9J74DWkXidP921FJQgWGE5 (SOL, other tokens or other networks will be lost).

Extension Homepage
https://fetelabs.ai/#lab

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • water.js:446
    GLib.file_get_contents(json)
  • wordText.js:21
    file.load_contents(null)

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 7 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • water.js:78
    console.error(`Water Panel: cannot offer the power-up on D-Bus: ${e}`)
  • water.js:459
    console.error(`Water Panel: cannot play ${sound}: ${e}`)
  • water.js:531
    console.error(`Water Panel: cannot read the wordmark font: ${e}`)
  • water.js:656
    console.error(`Water Panel: cannot work out colours: ${e}\n${e?.stack}`)
  • water.js:869
    console.error(`Water Panel: cannot start analyzer: ${e}`)
  • water.js:448
    console.warn(`Water Panel: no aura envelope for ${sound} (run aura-envelope.py): ${e}`)
  • water.js:884
            console.warn('Water Panel: the audio analyzer keeps exiting. ' +
              'Check that python3, python3-numpy and parec (pulseaudio-utils) are installed.')

All Versions

Version Status
12 Unreviewed
11 Rejected
10 Rejected
9 Rejected
8 Rejected
7 Rejected
6 Rejected
5 Rejected
4 Rejected
3 Rejected
2 Rejected
1 Rejected