Review of "Dynamic Island" version 2.0 (1)

Details Page Preview

iOS-style live island that shows what's playing (Spotify, browsers, any MPRIS player). Also shows volume and brightness, charger, screen recording, Bluetooth devices and download progress. Hover to expand, click to open the player.

Extension Homepage
https://github.com/basskibo/linux_dynamic_island

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:130
    this._art = new St.Bin({style_class: 'di-art', width: ART_SMALL, height: ART_SMALL, pivot_point: new Graphene.Point({x: 0.5, y: 0.5})})
  • extension.js:132
    this._artist = new St.Label({style_class: 'di-artist', visible: false})
  • extension.js:153
    this._chips = new St.BoxLayout({style_class: 'di-chips', visible: false, y_align: Clutter.ActorAlign.CENTER})
  • extension.js:147
    this._controls = new St.BoxLayout({visible: false, y_align: Clutter.ActorAlign.CENTER})
  • extension.js:139
    this._eq = new St.BoxLayout({style_class: 'di-eq', y_align: Clutter.ActorAlign.CENTER})
  • extension.js:135
    this._text = new St.BoxLayout({style_class: 'di-text', vertical: true, y_align: Clutter.ActorAlign.CENTER})
  • extension.js:131
    this._title = new St.Label({style_class: 'di-title'})
  • extension.js:159
    this._toastBar = new St.Widget({style_class: 'di-level', width: BAR_W, y_align: Clutter.ActorAlign.CENTER, layout_manager: new Clutter.BinLayout()})
  • extension.js:161
    this._toastBox = new St.BoxLayout({style_class: 'di-toast', visible: false, y_align: Clutter.ActorAlign.CENTER})
  • extension.js:158
    this._toastFill = new St.Widget({style_class: 'di-level-fill', width: 0})
  • extension.js:155
    this._toastIcon = new St.Icon({style_class: 'di-toast-icon'})
  • extension.js:156
    this._toastLabel = new St.Label({style_class: 'di-toast-label', y_align: Clutter.ActorAlign.CENTER})
  • extension.js:144
    bar

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:173
            this._island.connect('button-release-event', (actor, event) => {
                if (event.get_button() !== Clutter.BUTTON_PRIMARY)
                    return Clutter.EVENT_PROPAGATE;
                this._current?.raise();
                return Clutter.EVENT_STOP;
            })
  • extension.js:180
    this._island.connect('notify::height', () => this._reposition())
  • extension.js:172
    this._island.connect('notify::hover', () => this._setExpanded(this._island.hover))
  • extension.js:179
    this._island.connect('notify::width', () => this._reposition())
  • extension.js:559
            this._timerToggle.connect('clicked', () => {
                if (this._timer)
                    this._stopTimer();
                else
                    this._timerToggle.menu.open();
            })
  • extension.js:367
            p.connect('changed', () => {
                // A player that starts playing takes over the island
                if (p.status === 'Playing' || !this._current)
                    this._current = p;
                this._updateMusic();
            })
  • extension.js:373
            p.connect('closed', () => {
                if (!this._players)
                    return;
                this._players.delete(busName);
                if (this._current === p) {
                    const rest = [...this._players.values()];
                    this._current = rest.find(x => x.status === 'Playing

All Versions

Version Status
3.6 (7) Active
3.4 (6) Active
3.3 (5) Rejected
3.3 (4) Inactive
3.1 (3) Rejected
3.0 (2) Active
2.0 (1) Rejected

Previous Reviews on this Version

JustPerfection waiting for author
Is this code generated by AI? If so, we have a rule for that: [EGO Review Guidelines: AI](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#extensions-must-not-be-ai-generated)
basskibo posted a review
Yes, I built it with the help of an AI assistant (Claude Code). I tested it on my GNOME 46, reworked it, and I can explain any part of the code. I have also simplified it since submitting and would be hppy to make any changes you need.
JustPerfection rejected
1. Please remove version from the import (line 1 `extension.js`). 2. Please fix the entry point in `extension.js` smaller: [Extension Best Practices Guidelines: Keep the Default Entry Point as Small as Possible](https://gjs.guide/extensions/review-guidelines/best-practices.html#keep-the-default-entry-point-as-small-as-possible) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions