Review of "Valyuta məzənnəsi" version 0.1.0 (1)

Details Page Preview

🇦🇿 AMB tərəfindən dərc olunan rəsmi məzənnələr əsasında Azərbaycan manatının digər valyutalara nisbətini panel menyusunda göstərir. Mənbə: Azərbaycan Respublikası Mərkəzi Bankı (cbar.az). 🏴󠁧󠁢󠁥󠁮󠁧󠁿 Shows Azerbaijani Manat (AZN) exchange rates published by the Central Bank of Azerbaijan (CBAR) in the top panel.

Extension Homepage
https://gitlab.com/nicatt/valyuta-extension

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli did not find any issues.

All Versions

Version Status
0.1.1 (2) Active
0.1.0 (1) Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please remove version from import (line 5 `extension.js`). 2. Use icons instead of emjoi/ascii (line 219 `extension.js`): [Extension Best Practices Guidelines: Icons vs. Emojis](https://gjs.guide/extensions/review-guidelines/best-practices.html#ui-elements-icons-vs-emojis) 3. No need to use `this.initTranslations()`: - line 590 `extension.js` - line 17 `prefs.js` > Consider this method deprecated. > Only specify gettext-domain in metadata.json. > GNOME Shell can automatically initiate the translation for you > when it sees the gettext-domain key in metadata.json. [Port Guide 45: Extension Utils](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#extensionutils) 4. Don't store any instance of objects in a property in the default class you are exporting in `prefs.js`. that won't allow the garbage collector to do its job after window close: [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) Make them local to `fillPreferencesWindow()` function or clean up on: ```js window.connect('close-request', () => { // clean up here }); ``` 5. Add to the description that this extension is using `cbar.az` services. 6. I see AI patterns here, Please note, we have a rule for that: - [EGO Review Guidelines: AI](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#extensions-must-not-be-ai-generated) - [Extensions Best Practices Guidelines](https://gjs.guide/extensions/review-guidelines/best-practices.html#submissions-require-maintainership) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions