Review of "Twingate Quick Access" version 2.0.6 (1)

Details Page Preview

Private access, at home in GNOME. Quick Settings, pause/resume, searchable favorites, account switching, and resource actions for the official Twingate Linux client. Copies resource addresses and diagnostics to the clipboard when you select those actions. Does not read clipboard contents. Fork maintained by aheinze. Originally created by urhend: https://github.com/urhend/twingate-panel Community extension, not affiliated with Twingate.

Extension Homepage
https://github.com/aheinze/twingate-quick-access

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 3 manual_review 1

Shexli found 5 issues that may need reviewer attention.

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • extension.js:245
    St.Clipboard.get_default()
  • menu.js:344
    St.Clipboard.get_default()

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:90
            this._quickScroll = new St.ScrollView({hscrollbar_policy: St.PolicyType.NEVER,
                vscrollbar_policy: St.PolicyType.AUTOMATIC, overlay_scrollbars: true})
  • extension.js:35
            this.toggle = new QuickSettings.QuickMenuToggle({title: 'Twingate',
                subtitle: 'Checking…', gicon: logo, toggleMode: false})

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:84
    this._panel = new PanelIndicator(this._logo)
  • extension.js:86
    this._quick = new QuickIndicator(this._logo)
  • extension.js:90
            this._quickScroll = new St.ScrollView({hscrollbar_policy: St.PolicyType.NEVER,
                vscrollbar_policy: St.PolicyType.AUTOMATIC, overlay_scrollbars: true})
  • extension.js:47
    this._settings = this.getSettings()
  • extension.js:35
            this.toggle = new QuickSettings.QuickMenuToggle({title: 'Twingate',
                subtitle: 'Checking…', gicon: logo, toggleMode: false})

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:94
            this._quick.toggle.connect('clicked', () => {
                const {status, busy} = this._controller.state;
                if (busy || status === 'unknown') return;
                if (status === 'missing' || status === 'error') this._quick.toggle.menu.open();
                else void this._controller.pr
  • extension.js:110
    this._quick.toggle.connect('notify::allocation', () => this._syncQuickMenuHeight())
  • extension.js:111
    this._quick.toggle.menu.actor.connect('notify::allocation', () => this._syncQuickMenuHeight())
  • extension.js:104
                menu.connect('open-state-changed', () => {
                    if (menu === this._quick.toggle.menu && menu.isOpen) this._syncQuickMenuHeight();
                    this._syncPolling();
                    if (menu.isOpen) void this._controller.refresh();
                })

EGO-M-004 error

metadata shell-version must only include plausible stable releases and at most one development release

Field `shell-version` contains invalid values, more than one development release, or implausible future releases.

metadata.json must be well-formed

  • metadata.json
    shell-version=['50', '51']

All Versions

Version Status
2.0.7 (2) Unreviewed
2.0.6 (1) Rejected

Previous Reviews on this Version

agentejo auto- rejected
Auto-rejected because of new version 2.0.7 (2) was uploaded