Review of "Dhruva" version 4.3 (21)

Details Page Preview

A clean and customizable dock for GNOME Shell. Features: • Hover zoom with six motion styles • Panel mode that brings the top bar into the dock • Window previews with peek • App folders with emoji or custom icons • Click and minimize animations • Blur, themes, running indicators and notification badges • Auto-hide that stays out of the way of games and fullscreen apps • Music Pill with synced lyrics • Clock, Recycle Bin, folder and drive modules • Any screen edge, any monitor The Music Pill fetches lyrics from lrclib.net.

Extension Homepage
https://github.com/narkagni/dhruva

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 2

Shexli found 3 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • src/core/AppManager.js:182
    file.load_contents(null)
  • src/core/AppManager.js:221
    file.load_contents(null)
  • src/core/DataPaths.js:68
    GLib.file_get_contents(path)

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 6 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • src/core/AppManager.js:152
    console.error(`[Dhruva] Failed to sync folder apps with GNOME Dash: ${e.message}`)
  • src/core/AppManager.js:186
    console.error(`[Dhruva] Failed to read dock order JSON: ${e.message}`)
  • src/core/AppManager.js:205
    console.error(`[Dhruva] Failed to write ${path}: ${e.message}`)
  • src/core/AppManager.js:240
    console.error(`[Dhruva] Failed to read dock state JSON: ${e.message}`)
  • src/core/AppManager.js:345
    console.error(`[Dhruva] Failed to save non-independent folders: ${e.message}`)
  • src/core/AppManager.js:405
    console.error(`[Dhruva] Failed to sync unpin with GNOME Dash: ${e.message}`)

EGO-M-004 error

metadata shell-version must only include plausible stable releases and at most one development release

Field `shell-version` contains invalid values, more than one development release, or implausible future releases.

metadata.json must be well-formed

  • metadata.json
    shell-version=['45', '46', '47', '48', '49', '50', '51']

All Versions

Version Status
5.1.5 (33) Active
5.1.4 (32) Inactive
5.1.3 (31) Inactive
5.1.2 (30) Inactive
5.1.1 (29) Inactive
5.1 (28) Inactive
5.0 (27) Inactive
4.9 (26) Inactive
4.9 (25) Rejected
4.7 (24) Inactive
4.6 (23) Rejected
4.3 (22) Rejected
4.3 (21) Rejected
4.3 (20) Rejected
3.1 (19) Rejected
3.1 (18) Rejected
2.0 (17) Inactive
1.5 (16) Inactive
1.4 (15) Inactive
1.2 (14) Inactive
1.2 (13) Inactive
1.1 (12) Inactive
11 Inactive
10 Inactive
9 Rejected
8 Rejected
7 Rejected
6 Rejected
5 Rejected
4 Inactive
3 Inactive
2 Rejected
1 Rejected

Previous Reviews on this Version

Narkagni auto- rejected
Auto-rejected because of new version 4.3 (22) was uploaded