Review of "llama-dbusd Manager" version 3

Details Page Preview

Manage and switch local llama.cpp models directly from the GNOME top bar. Requires the companion llama-dbusd daemon running on the host system.

Extension Homepage
https://github.com/token419/llama-dbusd-manager

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 1

Shexli found 2 issues that may need reviewer attention.

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:119
    this._availableBox = new St.BoxLayout(boxProps)
  • extension.js:103
            this._availableEmptyItem = new PopupMenu.PopupBaseMenuItem({
                reactive: false,
                can_focus: false,
            })
  • extension.js:134
            this._availableScrollItem = new PopupMenu.PopupBaseMenuItem({
                reactive: false,
                can_focus: false,
                style_class: 'llama-scroll-menu-item',
            })
  • extension.js:90
    this._availableSection = new PopupMenu.PopupMenuSection()
  • extension.js:42
    this._indicator = new PanelMenu.Button(0.5, this.metadata.name, false)
  • extension.js:77
    this._loadedSection = new PopupMenu.PopupMenuSection()
  • extension.js:62
            this._statusIcon = new St.Icon({
                style_class: 'llama-small-icon llama-status-icon',
                y_align: Clutter.ActorAlign.CENTER,
            })
  • extension.js:68
            this._statusLabel = new St.Label({
                style_class: 'llama-menu-title',
                x_expand: true,
                y_align: Clutter.ActorAlign.CENTER,
            })

EGO-M-004 error

metadata shell-version must only include plausible stable releases and at most one development release

Field `shell-version` contains invalid values, more than one development release, or implausible future releases.

metadata.json must be well-formed

  • metadata.json
    shell-version=['45', '46', '47', '48', '49', '50', '51']

All Versions

Version Status
3 Unreviewed
2 Rejected
1 Rejected