Review of "Vesperal" version 1

Details Page Preview

Tell time by the Sun: how long until the next sunrise or sunset, since the last one, or both, next to the clock. A small arc shows where the Sun stands along the day, or the Moon in its phase along the night. The menu lists dawn, sunrise, sunset and dusk in your local time, on the 12-hour or 24-hour clock of your desktop. Works anywhere on Earth, polar days and nights included, and fully offline. The location comes from the GNOME location services or is set manually. Optional notifications come ahead of dawn, sunrise, sunset or dusk. The preferences chart the day length through the year, with the solstices and equinoxes. Right-click the indicator to switch between remaining time, elapsed time and both.

Extension Homepage
https://github.com/kornifex/vesperal

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:566
    this.button = new PanelMenu.Button(0.5, name)

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:482
    this.actor.connect("repaint", () => this.#repaint())
  • extension.js:483
    this.actor.connect("style-changed", () => this.actor.queue_repaint())
  • extension.js:573
    secondaryClick.connect("recognize", actions.secondaryClick)

All Versions

Version Status
4 Unreviewed
3 Rejected
2 Active
1 Rejected

Previous Reviews on this Version

kornifex auto- rejected
Auto-rejected because of new version 2 was uploaded