Review of "Cascade Dock" version 1.0 (1)

Details Page Preview

A cascading-zoom dock that follows the mouse, featuring live window previews, a bounce effect when launching apps, indicators for open apps, and an autohide function. Your icons and theme remain unchanged. A cascading zoom dock with live window previews, launch bounce, running indicators, and autohide. Created by Fábio.

Extension Homepage
https://github.com/fabiorqueiroz/cascade-dock

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 2

Shexli found 3 issues that may need reviewer attention.

EGO-P-002 error

GSettings schema path must use /org/gnome/shell/extensions base

GSettings schema path must start with `/org/gnome/shell/extensions`.

GSettings Schemas

  • schemas/org.gnome.shell.extensions.cascade-dock.gschema.xml
    id='org.gnome.shell.extensions.cascade-dock' path='/org.gnome.shell.extensions.cascade-dock/'

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:226
            this._bg = new St.Widget({
                style: `background-color: rgba(${cr}, ${cg}, ${cb}, ${s.get_double('bg-opacity')}); ` +
                       `border-radius: ${s.get_int('corner-radius')}px; ${border}`,
            })
  • extension.js:264
            this._label = new St.Label({
                style: 'background-color: rgba(30, 30, 34, 0.92); color: white; ' +
                       'border-radius: 8px; padding: 3px 10px; font-size: 10.5pt;',
                reactive: false,
                visible: false,
                opacity: 0,
            })
  • extension.js:714
    this._menu = menu
  • extension.js:301
    this._menuManager = new PopupMenu.PopupMenuManager(this._root)
  • extension.js:297
    this._tl = new Clutter.Timeline({actor: this._root, duration: 1000, repeat_count: -1})

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:275
            this._root.connect('enter-event', (_a, e) => {
                this._clearTimer('hide');
                return this._onMotion(e);
            })
  • extension.js:279
    this._root.connect('leave-event', () => this._onLeave())
  • extension.js:274
    this._root.connect('motion-event', (_a, e) => this._onMotion(e))
  • extension.js:281
            this._root.connect('notify::visible', () => {
                if (this._root?.visible && !this._isShown())
                    this._root.hide();
            })
  • extension.js:298
    this._tl.connect('new-frame', () => this._tick())

All Versions

Version Status
1.0 (1) Unreviewed