Review of "Clipdeck" version 1

Details Page Preview

Clipboard history in the top bar. Click the clipboard icon to see everything you copied or cut (text, links, images, screenshots, files and videos) and copy any of it again.

Extension Homepage
https://github.com/JD-Tensor/clipdeck

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 3 manual_review 1

Shexli found 5 issues that may need reviewer attention.

EGO-X-003 warning

extensions should not call run_dispose in extension code

Extension code should not call `run_dispose()`.

GObject.Object.run_dispose

  • extension.js:136
    this._virtualKeyboard?.run_dispose()

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • extension.js:90
    St.Clipboard.get_default()

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:230
            this._popup.connect('closed', () => {
                this._popup = null;
                this._indicator?.remove_style_pseudo_class('active');
            })

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • extension.js:151
            this._captureId = GLib.timeout_add(GLib.PRIORITY_DEFAULT, CAPTURE_DELAY_MS, () => {
                this._captureId = 0;
                this._capture();
                return GLib.SOURCE_REMOVE;
            })
  • extension.js:259
            this._pasteId = GLib.timeout_add(GLib.PRIORITY_DEFAULT, PASTE_DELAY_MS, () => {
                this._pasteId = 0;
                this._sendPasteKeys();
                return GLib.SOURCE_REMOVE;
            })

EGO-M-004 error

metadata shell-version must only include plausible stable releases and at most one development release

Field `shell-version` contains invalid values, more than one development release, or implausible future releases.

metadata.json must be well-formed

  • metadata.json
    shell-version=['50', '51']

All Versions

Version Status
1 Unreviewed