Review of "Desktop LRC" version 2

Details Page Preview

Local desktop lyrics: reads "Artist - Title.lrc" beside your music files, follows any MPRIS player with a two-line staggered display, auto font-fit for long lines, gesture-based dragging, tray toggle, and a standalone GTK4 preferences window.

Extension Homepage
https://github.com/kgpche/desktop-lrc

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 6

Shexli found 6 issues that may need reviewer attention.

EGO-P-007 warning

JavaScript files should be reachable from extension.js or prefs.js

Some JavaScript files are not reachable from `extension.js` or `prefs.js` imports.

Don't include unnecessary files

  • prefs-app.js

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:756
    this._trayIcon = new St.Icon({icon_name: 'audio-x-generic-symbolic', style_class: 'system-status-icon'})

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:749
    this._settings = this.getSettings()
  • extension.js:756
    this._trayIcon = new St.Icon({icon_name: 'audio-x-generic-symbolic', style_class: 'system-status-icon'})

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:660
    this._gesture.connect('recognize', () => this._beginDrag())

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • extension.js:617
            GLib.idle_add(GLib.PRIORITY_DEFAULT, () => {
                if (!this._dead) this._applyAutoPos();
                return GLib.SOURCE_REMOVE;
            })

EGO-C45-001 warning

45+ preferences should use fillPreferencesWindow instead of getPreferencesWidget

45+ preferences code should use `fillPreferencesWindow()` instead of `getPreferencesWidget()`.

Preferences

  • prefs.js:8
        getPreferencesWidget() {
            return buildPrefsGrid(this.getSettings(), _);
        }

All Versions

Version Status
3 Unreviewed
2 Rejected
1 Unreviewed

Previous Reviews on this Version

kgpche auto- rejected
Auto-rejected because of new version 3 was uploaded