Review of "Shader Effects" version 1

Details Page Preview

Apply customizable GPU-powered shader effects to your GNOME desktop, including CRT scanlines, VHS distortion, RGB shifts, and more.

Extension Homepage
https://github.com/murat-cileli/gnome-shell-extension-shader-effects

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 3

Shexli found 4 issues that may need reviewer attention.

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:67
    this._animate = new PopupMenu.PopupSwitchMenuItem('Animate', true)
  • extension.js:26
    this._enabled = new PopupMenu.PopupSwitchMenuItem('Enable effects', false)
  • extension.js:55
    this._intensityLabel = new St.Label({text: 'Intensity', y_align: Clutter.ActorAlign.CENTER})
  • extension.js:30
    this._presetMenu = new PopupMenu.PopupSubMenuMenuItem('Effect')
  • extension.js:40
    this._scopeMenu = new PopupMenu.PopupSubMenuMenuItem('Apply to')
  • extension.js:50
    this._windowMenu = new PopupMenu.PopupSubMenuMenuItem('Selected windows')

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:67
    this._animate = new PopupMenu.PopupSwitchMenuItem('Animate', true)
  • extension.js:26
    this._enabled = new PopupMenu.PopupSwitchMenuItem('Enable effects', false)
  • extension.js:55
    this._intensityLabel = new St.Label({text: 'Intensity', y_align: Clutter.ActorAlign.CENTER})
  • extension.js:30
    this._presetMenu = new PopupMenu.PopupSubMenuMenuItem('Effect')
  • extension.js:40
    this._scopeMenu = new PopupMenu.PopupSubMenuMenuItem('Apply to')
  • extension.js:50
    this._windowMenu = new PopupMenu.PopupSubMenuMenuItem('Selected windows')

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:72
            this.menu.connect('open-state-changed', (_menu, open) => {
                if (open) {
                    this._rebuildWindows();
                    this.sync();
                }
            })

EGO-M-004 error

metadata shell-version must only include plausible stable releases and at most one development release

Field `shell-version` contains invalid values, more than one development release, or implausible future releases.

metadata.json must be well-formed

  • metadata.json
    shell-version=['50', '51']

All Versions

Version Status
7 Active
6 Inactive
5 Rejected
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

Murat Çileli auto- rejected
Auto-rejected because of new version 2 was uploaded