Review of "ThinkPad Presence Lock" version 0.1 (1)

Details Page Preview

Locks the screen when you walk away and wakes it when you come back, using the presence radar in the ThinkPad X1 Nano Gen 1 (tested) and similar 2021 X1 models (untested). Requires a udev rule, see the project page.

Extension Homepage
https://github.com/ImaginationZ/thinkpad-presence-lock

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • extension.js:41
    GLib.file_get_contents(path)

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:284
                this._notificationSource.connect('destroy', () => {
                    this._notificationSource = null;
                })

EGO-M-008 warning

extensions using unlock-dialog must document it in disable() comments

Extensions using `unlock-dialog` should document the reason in `disable()` comments.

Session Modes

  • extension.js:190
        disable() {
            this._stopRadar();
            Main.sessionMode.disconnectObject(this);
            this._settings.disconnectObject(this);
            this._settings = null;
            this._updateInhibit();
            this._indicator.destroy();
            this._indicator = null;
            this._notificationSource

All Versions

Version Status
0.1 (1) Unreviewed