Review of "GameMode Indicator" version 1

Details Page Preview

Adds a GameMode indicator to the quick settings

Extension Homepage
https://github.com/Ratewio/Gnome-GameMode-Indicator

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Package contains files that often should not be shipped for review.

Don't include unnecessary files

  • stylesheet.css
    placeholder stylesheet.css

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:90
    this._indicator = new GameModeIndicator(this.path)

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:59
                        this._signalId = this._proxy.connect(
                            'g-properties-changed',
                            (proxy, changed) => {
                                if (changed.lookup_value('ClientCount', null) !== null)
                                    this._sync();
                      

All Versions

Version Status
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

Ratewio auto- rejected
Auto-rejected because of new version 2 was uploaded