Review "Monitor Input & Brightness" version 1 - GNOME Shell Extensions

Review of "Monitor Input & Brightness" version 1

Details Page Preview

Monitor Input & Brightness

by cviegas

Switch the input source and set the brightness of your external monitors from the top bar, using DDC/CI (ddcutil).

Extension Homepage: https://github.com/cezou/monitor-input-brightness

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

extension.js:99

this.section = new PopupMenu.PopupMenuSection()

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

extension.js:197

        this.menu.connect('open-state-changed', (_menu, open) => {
            if (open)
                this._monitors.forEach(m => m.refresh());
        })

All Versions

Version	Status
1	Unreviewed