EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 10 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

• extension.js:75

  console.warn(`lovycairn: shortcut ${k} was rejected`)

• extension.js:192

  console.error('lovycairn: AppMenu.setApp not found, menu entry not added')

• extension.js:204

  console.error(`lovycairn: menu entry not added: ${e}`)

• extension.js:255

  console.error(`lovycairn: ${file}: ${e}`)

• extension.js:295

  console.error(`lovycairn: reading ${DESKTOP_DIR} failed: ${e}`)

• extension.js:710

  console.error(`lovycairn: launching ${name} failed: ${e}`)

• extension.js:828

  console.error(`lovycairn: browser not started: ${e}`)

• extension.js:907

  console.error(`lovycairn: cannot create ${file}: ${e}`)

• extension.js:946

  console.error(`lovycairn: folder ${path}: ${e}`)

• extension.js:1008

  console.error(`lovycairn: cannot trash ${name}: ${e}`)

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

• groups.js:54

  GLib.file_get_contents(GLib.build_filenamev([path, MARKER]))

• notes.js:29

  GLib.file_get_contents(GLib.build_filenamev([dir, name]))

• util.js:18

  GLib.file_get_contents(path)

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 6 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

• groups.js:138

  console.error(`lovycairn: reading ${path} failed: ${e}`)

• groups.js:241

  console.error(`lovycairn: moving ${src} failed: ${e}`)

• groups.js:274

  console.error(`lovycairn: creating group ${p} failed: ${e}`)

• groups.js:294

  console.error(`lovycairn: renaming ${path} failed: ${e}`)

• groups.js:329

  console.error(`lovycairn: ungrouping ${path} failed: ${e}`)

• groups.js:447

  console.error(`lovycairn: appearance of ${path}: ${e}`)

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

• extension.js:55

  this._monitor.connect('changed', () => this._queueSync())

• extension.js:1041

          menu.connect('open-state-changed', (_m, open) => {
              if (open)
                  return;
              GLib.idle_add(GLib.PRIORITY_DEFAULT, () => {
                  if (this._menu === menu)
                      this._menu = null;
                  manager.destroy?.();
                  menu.

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

• extension.js:1044

              GLib.idle_add(GLib.PRIORITY_DEFAULT, () => {
                  if (this._menu === menu)
                      this._menu = null;
                  manager.destroy?.();
                  menu.destroy();
                  return GLib.SOURCE_REMOVE;
              })

• extension.js:180

  id