Review of "QR Code Generator" version 1

Details Page Preview

Enter or paste your text then display a QR code, copied to the clipboard. Button in top panel. Very light extension.

Extension Homepage
https://github.com/fthx/qrcode

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2 manual_review 1

Shexli found 3 issues that may need reviewer attention.

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • extension.js:76
    St.Clipboard.get_default()
  • extension.js:96
    St.Clipboard.get_default()

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:35
    this._entry = new St.Entry({ hintText: '...', canFocus: true, width: QR_CODE_SIZE })

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:35
    this._entry = new St.Entry({ hintText: '...', canFocus: true, width: QR_CODE_SIZE })

All Versions

Version Status
2 Active
1 Rejected

Previous Reviews on this Version

fthx auto- rejected
Auto-rejected because of new version 2 was uploaded