Review of "Gnome Muzei Wallpaper" version 3

Details Page Preview

GNOME Shell extension using Muzei Featured Art, with adjustable blur, dim, greyscale, and accent color.

Extension Homepage
https://gitlab.com/komfushee/gnome-muzei-wallpaper/

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 7 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • extension.js:295
    console.warn('[Gnome Muzei Wallpaper] Blur needs ImageMagick. Install it with: sudo dnf install ImageMagick. Using the sharp image instead of a black/invalid wallpaper.')
  • extension.js:138
    console.error(`[Gnome Muzei Wallpaper] Refresh failed: ${error.message}`)
  • extension.js:153
    console.error(`[Gnome Muzei Wallpaper] Could not read artwork for accent color: ${error.message}`)
  • extension.js:199
    console.error(`[Gnome Muzei Wallpaper] Could not update GNOME accent color: ${error.message}`)
  • extension.js:279
    console.error(`[Gnome Muzei Wallpaper] Could not set wallpaper: ${error.message}`)
  • extension.js:325
    console.error(`[Gnome Muzei Wallpaper] Could not start ImageMagick: ${error.message}`)
  • extension.js:348
    console.error(`[Gnome Muzei Wallpaper] Blur generation failed: ${error.message}`)

All Versions

Version Status
6.1.0 (7) Unreviewed
6.0.0 (6) Rejected
5 Rejected
4 Inactive
3 Rejected
2 Inactive
1 Rejected

Previous Reviews on this Version

komfushee posted a review
JustPerfection rejected
1. Please remove version from the import (line 5 `extension.js`). 2. Remove `this._enabled`: https://gjs.guide/extensions/review-guidelines/best-practices.html#lifecycle-and-destruction-state 3. Please use `connectObject()` and `disconnectObject()` so it is easier to track for cleanup.