Review of "Equalizer" version 1

Details Page Preview

A six band equalizer with loudness equalization and bass boost for the sound output. Adds an equalizer button next to the volume slider in the system menu. The audio processing runs in the gnome-equalizer service, installed with the Equalizer app.

Extension Homepage
https://github.com/cloudie-code/gnome-equalizer

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 2 warning 3

Shexli found 5 issues that may need reviewer attention.

EGO-P-001 error

GSettings schema id must use org.gnome.shell.extensions base

GSettings schema id must start with `org.gnome.shell.extensions`.

GSettings Schemas

  • schemas/io.github.cloudie_code.equalizer.gschema.xml
    id='io.github.cloudie_code.equalizer' path='/io/github/cloudie_code/equalizer/'

EGO-P-002 error

GSettings schema path must use /org/gnome/shell/extensions base

GSettings schema path must start with `/org/gnome/shell/extensions`.

GSettings Schemas

  • schemas/io.github.cloudie_code.equalizer.gschema.xml
    id='io.github.cloudie_code.equalizer' path='/io/github/cloudie_code/equalizer/'

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:211
    this._bands = new EqualizerBands(this._settings)
  • extension.js:233
    this._bassItem = new PopupMenu.PopupSwitchMenuItem(_('Bass Boost'), false)
  • extension.js:228
    this._loudnessItem = new PopupMenu.PopupSwitchMenuItem(_('Loudness Equalization'), false)
  • extension.js:261
    this._menuManager = new PopupMenu.PopupMenuManager(this._output)
  • extension.js:215
    this._presetMenu = new PopupMenu.PopupSubMenuMenuItem(_('Preset'))
  • extension.js:194
    this._switch = new PopupMenu.Switch(this._settings.get_boolean('enabled'))

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:211
    this._bands = new EqualizerBands(this._settings)
  • extension.js:233
    this._bassItem = new PopupMenu.PopupSwitchMenuItem(_('Bass Boost'), false)
  • extension.js:228
    this._loudnessItem = new PopupMenu.PopupSwitchMenuItem(_('Loudness Equalization'), false)
  • extension.js:215
    this._presetMenu = new PopupMenu.PopupSubMenuMenuItem(_('Preset'))
  • extension.js:194
    this._switch = new PopupMenu.Switch(this._settings.get_boolean('enabled'))

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:179
    this._button.connect('clicked', () => this._menu.toggle())
  • extension.js:243
            this._menu.connect('open-state-changed', (_m, isOpen) => {
                qsMenu._setDimmed(isOpen);
                qsMenu._activeMenu = isOpen ? this._menu : null;
                if (isOpen)
                    this._button.add_style_pseudo_class('checked');
                else
                    this._button

All Versions

Version Status
2 Unreviewed
1 Rejected

Previous Reviews on this Version

Cloudie.Code auto- rejected
Auto-rejected because of new version 2 was uploaded