Review of "Network Speed" version 2

Details Page Preview

Live download and upload speed in the GNOME top panel. Lightweight local extension for GNOME Shell 51.

Extension Homepage
https://github.com/marufallammahim

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • extension.js:13
    GLib.file_get_contents(path)

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:86
            this._detailsItem = new PopupMenu.PopupMenuItem('Detecting network…', {
                reactive: false,
                can_focus: false,
            })
  • extension.js:80
            this._label = new St.Label({
                text: '↓ --  ↑ --',
                y_align: Clutter.ActorAlign.CENTER,
            })

All Versions

Version Status
2 Unreviewed
1 Rejected