Review "MCP Indicator" version 1 - GNOME Shell Extensions

Review of "MCP Indicator" version 1

Details Page Preview

MCP Indicator

Shows MCP (Model Context Protocol) servers from this computer in the GNOME top bar: running, degraded, stopped or remote. Start, stop and restart apply only to local HTTP or systemd daemons; client-managed stdio is left to the IDE. Copies an MCP URL or systemd journal logs to the clipboard when you click those buttons. Clipboard contents and process data are never sent to third parties.

Extension Homepage: https://github.com/rodriguesfas/mcp-indicator

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2 manual_review 1

Shexli found 3 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

control.js:37
```
file.load_contents(null)
```

control.js:184

Gio.File.new_for_path(`/proc/${pid}/cmdline`).load_contents(null)

detector.js:110
```
file.load_contents(null)
```
detector.js:278
```
cmdFile.load_contents(null)
```

detector.js:286

Gio.File.new_for_path(`/proc/${name}/comm`).load_contents(null)

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

extension.js:448
```
St.Clipboard.get_default()
```
extension.js:485
```
St.Clipboard.get_default()
```

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

extension.js:228

        this._source.connect('destroy', () => {
            this._source = null;
        })

All Versions

Version	Status
1	Unreviewed