Review of "DDC Monitor Control" version 4

Details Page Preview

Control external monitor brightness, contrast, volume, input source and color preset over DDC/CI from Quick Settings. Requires ddcutil.

Extension Homepage
https://github.com/kobi3455/ddc-monitor-control

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • libs/libpanel/main.js:581
            this._width_constraint = new Clutter.BindConstraint({
                coordinate: Clutter.BindCoordinate.WIDTH,
                source: null,
            })

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • libs/libpanel/main.js:581
            this._width_constraint = new Clutter.BindConstraint({
                coordinate: Clutter.BindCoordinate.WIDTH,
                source: null,
            })

All Versions

Version Status
5 Unreviewed
4 Rejected
3 Unreviewed
2 Rejected
1 Rejected

Previous Reviews on this Version

kobi3455 auto- rejected
Auto-rejected because of new version 5 was uploaded