Review of "SSH Connections" version 1

Details Page Preview

A GNOME Shell extension for saving, grouping, monitoring, and quickly opening SSH connections.

Extension Homepage
https://github.com/pstrakeljahn/ssh-connections

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:107
    this._panelIcon = new St.Icon({icon_name: 'network-server-symbolic', style_class: 'ssh-panel-icon'})
  • extension.js:108
    this._summary = new St.Label({text: '', style_class: 'ssh-panel-summary'})

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:107
    this._panelIcon = new St.Icon({icon_name: 'network-server-symbolic', style_class: 'ssh-panel-icon'})
  • extension.js:108
    this._summary = new St.Label({text: '', style_class: 'ssh-panel-summary'})

EGO-L-006 warning

preferences classes should not retain window-scoped objects on instance fields without close-request cleanup

Preferences code stores window-scoped objects on the exported prefs class without `close-request` cleanup.

Destroy all objects

  • prefs.js:15
    this._settings = this.getSettings()
  • prefs.js:39
    this._categoryList = new Gtk.ListBox({selection_mode: Gtk.SelectionMode.NONE, css_classes: ['boxed-list']})
  • prefs.js:42
    this._categoryEntry = new Gtk.Entry({placeholder_text: TEXT.categoryPlaceholder, hexpand: true})
  • prefs.js:50
    this._list = new Gtk.ListBox({selection_mode: Gtk.SelectionMode.NONE, css_classes: ['boxed-list']})

All Versions

Version Status
1 Unreviewed