Review of "Where is my HTB IP?" version 1.0.0 (1)

Details Page Preview

Shows a cube and the IP of your active Hack The Box machine in the top bar while a VPN (tun/tap) is up. Click it to copy the IP. Needs an HTB App Token (Labs > Account Settings > App Tokens).

Extension Homepage
https://github.com/JimyHN/Where-is-my-HTB-IP

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1 manual_review 2

Shexli found 3 issues that may need reviewer attention.

EGO-A-001 manual_review

extension code must not be minified or obfuscated

File appears obfuscated: 57% of identifiers are 1–2 characters (avg length 3.3).

Code must not be obfuscated

  • cube.js
    short identifier ratio: 57%, identifiers scored: 44

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • extension.js:95
    St.Clipboard.get_default()

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • extension.js:195
            this._settleId = GLib.timeout_add_seconds(GLib.PRIORITY_DEFAULT, SETTLE_SECONDS, () => {
                this._settleId = null;
                this._place(false);
                return GLib.SOURCE_REMOVE;
            })
  • extension.js:202
            this._timeoutId = GLib.timeout_add_seconds(
                GLib.PRIORITY_DEFAULT, VPN_CHECK_SECONDS, () => {
                    this._tick();
                    return GLib.SOURCE_CONTINUE;
                })
  • extension.js:105
            this._rippleId = GLib.timeout_add(GLib.PRIORITY_DEFAULT, 16, () => {
                this._progress = Math.min(1, (GLib.get_monotonic_time() - start) / (RIPPLE_MS * 1000));
                this._ripple.queue_repaint();
                if (this._progress >= 1) {
                    this._rippleId = 0;
          

All Versions

Version Status
1.0.0 (1) Unreviewed