Review of "Tray Overflow" version 1.2 (2)

Details Page Preview

Collapse extra tray icons (AppIndicator / KStatusNotifierItem) behind a chevron in the top bar. Drag and drop icons onto the chevron to hide them, or onto a visible icon to keep them shown; choices and order are remembered per app. Requires the AppIndicator support extension.

Extension Homepage
https://github.com/piharpi/tray-overflow

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:202
            draggable.connect('drag-begin', () => {
                // Cancel the pending click/activation from ubuntu-appindicators
                ind._waitDoubleClickPromise?.cancel();
                ind.menu?.close?.();
                this._setDragging(true);
            })
  • extension.js:208
    draggable.connect('drag-end', () => this._setDragging(false))

All Versions

Version Status
1.2 (3) Unreviewed
1.2 (2) Rejected
1.1 (1) Rejected

Previous Reviews on this Version

harpi auto- rejected
Auto-rejected because of new version 1.2 (3) was uploaded