Review of "System Monitor Mini" version 1.3 (2)

Details Page Preview

CPU usage, RAM usage and CPU temperature in the top bar, with history graphs on click or hover.

Extension Homepage
https://github.com/piharpi/sysmon

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • extension.js:27
    GLib.file_get_contents(path)

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:269
            this._click.connect('recognize', () => {
                if (this.menu.isOpen && this._hoverOpened)
                    this._stopHover();
                else
                    this.menu.toggle();
            })
  • extension.js:278
            this.menu.connect('open-state-changed', (menu, open) => {
                if (!open)
                    this._stopHover();
                else
                    this._redrawGraphs();
            })

All Versions

Version Status
1.4 (3) Unreviewed
1.3 (2) Rejected
1.2 (1) Rejected

Previous Reviews on this Version

harpi posted a review
harpi auto- rejected
Auto-rejected because of new version 1.4 (3) was uploaded