Review of "ClusterCut" version 4.2 (8)

Details Page Preview

Integration for ClusterCut Clipboard Sync. Adds a Quick Settings toggle and reads/writes the system clipboard to enable clipboard sync on Wayland.

Extension Homepage
https://github.com/keithvassallomt/ClusterCut

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1 manual_review 1

Shexli found 2 issues that may need reviewer attention.

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • extension.js:490
    St.Clipboard.get_default()
  • extension.js:543
    St.Clipboard.get_default()
  • extension.js:565
    St.Clipboard.get_default()
  • extension.js:618
    St.Clipboard.get_default()
  • extension.js:676
    St.Clipboard.get_default()
  • extension.js:768
    St.Clipboard.get_default()
  • extension.js:801
    St.Clipboard.get_default()
  • extension.js:836
    St.Clipboard.get_default()
  • extension.js:983
    St.Clipboard.get_default()
  • extension.js:992
    St.Clipboard.get_default()
  • extension.js:996
    St.Clipboard.get_default()
  • extension.js:1007
    St.Clipboard.get_default()
  • extension.js:1012
    St.Clipboard.get_default()

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • extension.js:978
    id

All Versions

Version Status
4.2 (9) Active
4.2 (8) Rejected
4.1 (7) Active
4.0 (6) Active
3.0 (5) Active
2.0 (4) Active
1.1 (3) Rejected
1.0 (2) Active
1.0 (1) Rejected

Previous Reviews on this Version

Keith Vassallo auto- rejected
Auto-rejected because of new version 4.2 (9) was uploaded