Review of "Letterbox Display" version 1

Details Page Preview

Fit a centered 16:9 desktop area on the primary monitor at any resolution. Fullscreen content is masked, not resized.

Extension Homepage
https://github.com/necrotree/letterbox-display

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:88
                this._topReservation = new St.Widget({name: 'letterbox-panel-reservation',
                    reactive: false, can_focus: false, style: 'background-color: transparent;'})

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:25
    this._panelHeightId = Main.layoutManager.panelBox.connect('notify::height', () => this._resizeReservation())
  • extension.js:24
    this._panelWidthId = Main.layoutManager.panelBox.connect('notify::width', () => this._positionPanel())
  • extension.js:22
    this._panelXId = Main.layoutManager.panelBox.connect('notify::x', () => this._positionPanel())
  • extension.js:23
    this._panelYId = Main.layoutManager.panelBox.connect('notify::y', () => this._positionPanel())

All Versions

Version Status
1 Unreviewed