Review of "Sun Wallpaper" version 1

Details Page Preview

Automatic wallpaper based on solar time

Extension Homepage
https://github.com/Nurdin027/sunwallpaper-Nurdin027

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:31
            this._label = new St.Label({
                text: 'Loading solar data...',
                y_align: Clutter.ActorAlign.CENTER,
            })
  • extension.js:107
    this._locationItem = new PopupMenu.PopupMenuItem('Location: --')
  • extension.js:99
            this._statusItem = new PopupMenu.PopupMenuItem(
                'Waiting for API...'
            )

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • extension.js:45
            this._apiTimeoutId = GLib.timeout_add_seconds(
                GLib.PRIORITY_DEFAULT,
                API_REFRESH_SECONDS,
                () => {
                    this._refreshApi();
                    return GLib.SOURCE_CONTINUE;
                }
            )
  • extension.js:53
            this._clockTimeoutId = GLib.timeout_add_seconds(
                GLib.PRIORITY_DEFAULT,
                CLOCK_REFRESH_SECONDS,
                () => {
                    this._updatePhase();
                    return GLib.SOURCE_CONTINUE;
                }
            )

All Versions

Version Status
1 Unreviewed