Review of "Spinning Cat" version 1

Details Page Preview

A spinning cat sketch in the top-left corner of the panel.

Extension Homepage
https://github.com/melamann00/spinningcat

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:28
            this._icon = new St.Icon({
                gicon: this._frames[0],
                icon_size: ICON_SIZE,
                y_align: Clutter.ActorAlign.CENTER,
            })

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:36
            this._button.connect('button-press-event', () => {
                Main.overview.toggle();
                return Clutter.EVENT_STOP;
            })

All Versions

Version Status
1 Unreviewed