Review "Coffee Check" version 1.0 (1) - GNOME Shell Extensions

Review of "Coffee Check" version 1.0 (1)

Details Page Preview

Coffee Check

by gryfen99

Track your coffee's temperature in real time and get notified when it's ready to drink.

Extension Homepage: https://github.com/e-o-r-a-n/coffee-check.git

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

extension.js:174

        this.timeout = GLib.timeout_add_seconds(GLib.PRIORITY_DEFAULT, 1, () => {
            const result = this._refresh();
            if (result === GLib.SOURCE_REMOVE)
                this.timeout = null;
            return result;
        })

All Versions

Version	Status
1.0 (1)	Unreviewed