Review of "NetIdent" version 1.2.0 (5)

Details Page Preview

Network identity indicator showing external IP, VPN status, Tailscale, DNS, routing, and all active connections.

Extension Homepage
https://github.com/dvdstelt/netident

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2 manual_review 1

Shexli found 3 issues that may need reviewer attention.

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • extension.js:1419
    St.Clipboard.get_default()

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • traffic.js:145
    GLib.file_get_contents('/proc/net/dev')

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:420
    this._graph.connect('repaint', area => this._drawGraph(area))
  • extension.js:403
    this._ifaceButton.connect('clicked', () => this._cycleTrafficInterface())
  • extension.js:487
    this._speedButton.connect('clicked', () => this._onSpeedTestClicked())
  • extension.js:558
            this._tailscaleToggle.connect('toggled',
                (_item, state) => this._onTailscaleToggled(this._tailscaleToggle, state))
  • extension.js:241
            this.menu.connect('open-state-changed', (_menu, open) => {
                if (open)
                    this._onMenuOpened();
                else
                    this._onMenuClosed();
            })
  • extension.js:492
    refreshButton.connect('clicked', () => this._refresh(true))
  • extension.js:553
    selfCopy.connect('clicked', () => this._copyText(this._tailscale?.tailscaleIp, _('Tailscale IP copied to clipboard')))
  • extension.js:496
            settingsButton.connect('clicked', () => {
                this._extension.openPreferences();
                this.menu.close();
            })

All Versions

Version Status
1.2.1 (6) Unreviewed
1.2.0 (5) Rejected
1.1.0 (4) Unreviewed
1.0 (3) Active
1.0 (2) Rejected
1.0 (1) Active

Previous Reviews on this Version

dvdstelt auto- rejected
Auto-rejected because of new version 1.2.1 (6) was uploaded