Review of "KnockDock" version 1.0.0 (2)

Details Page Preview

Animated dock, top bar customization and magic lamp window animations in a single desktop management extension.

Extension Homepage
https://www.gnome-look.org/

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 4

Shexli found 5 issues that may need reviewer attention.

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 6 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • animator.js:117
    console.log('unable to layout()')
  • animator.js:1118
    console.log(err)
  • animator.js:1146
    console.log(err)
  • animator.js:1173
    console.log(err)
  • animator.js:1204
    console.log(err)
  • animator.js:1217
    console.log(err)
  • services.js:414
    console.log(`checking ${path}`)
  • services.js:541
    console.log('checking recent manager')
  • services.js:553
    console.log(err)
  • services.js:572
    console.log('not exists')
  • services.js:589
    console.log(err)
  • services.js:628
    console.log(err)

EGO-C49-004 error

extensions targeting GNOME 49 must not call Meta.Window.get_maximized

This extension explicitly targets GNOME Shell 49 but still calls removed `Meta.Window.get_maximized()`.

Meta.Window

  • dock.js:1581
    focusedWindow.get_maximized()

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 17 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • extension.js:128
    console.log(`knockdock: undock failed: ${e}`)
  • extension.js:245
    console.log(e)
  • extension.js:247
    console.log('knockdock enabled')
  • extension.js:251
    console.log(`knockdock: deferred startUp failed: ${e}`)
  • extension.js:297
    console.log('knockdock disabled')
  • extension.js:335
    console.log(`knockdock: createTheDocks failed: ${e}`)
  • extension.js:374
              console.log(
                `knockdock: dock vis=${d.visible} op=${d.opacity} renderOp=${d.renderArea?.opacity} pos=${d.x},${d.y} size=${d.width}x${d.height} icons=${d._icons ? d._icons.length : 'null'} struts=${d.struts ? d.struts.width + 'x' + d.struts.height : 'none'} chrome=${d._onChrome}
  • extension.js:378
    console.log(`knockdock diag err ${e}`)
  • extension.js:418
    console.log(err)
  • extension.js:458
    console.log(`loading icon ${file.get_path()}`)

EGO-P-007 warning

JavaScript files should be reachable from extension.js or prefs.js

Some JavaScript files are not reachable from `extension.js` or `prefs.js` imports.

Don't include unnecessary files

  • apps/overlay.js
  • apps/recents.js
  • effects/blur_effect.js
  • effects/color_effect.js
  • prefs-standalone.js

EGO-L-006 warning

preferences classes should not retain window-scoped objects on instance fields without close-request cleanup

Preferences code stores window-scoped objects on the exported prefs class without `close-request` cleanup.

Destroy all objects

  • prefs.js:233
    this._monitorsConfig = new MonitorsConfig()

All Versions

Version Status
1.0.0 (2) Unreviewed
1.0.0 (1) Rejected