Review of "Smartphone Remote Control" version 0.6.0 (1)

Details Page Preview

Use a smartphone browser as a desktop touchpad and keyboard. Connect over your local network with encrypted transport and desktop approval. Copies pairing links to the clipboard on request. Scan a temporary QR code to pair your phone.

Extension Homepage
https://github.com/jfernandz/gnome-shell-smartphone-rc

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 3 manual_review 1

Shexli found 5 issues that may need reviewer attention.

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • extension.js:44
    St.Clipboard.get_default()

EGO-P-002 error

GSettings schema path must use /org/gnome/shell/extensions base

GSettings schema path must start with `/org/gnome/shell/extensions`.

GSettings Schemas

  • schemas/org.gnome.shell.extensions.smartphone-rc.browser.gschema.xml
    id='org.gnome.shell.extensions.smartphone-rc.browser' path=''

EGO-P-007 warning

JavaScript files should be reachable from extension.js or prefs.js

Some JavaScript files are not reachable from `extension.js` or `prefs.js` imports.

Don't include unnecessary files

  • app/network-guard.js
  • app/server.js
  • app/service-worker.js
  • app/session-authorization.js
  • app/web/app.js
  • app/web/client.js
  • app/web/editing.js
  • app/web/keyboard.js
  • app/web/touchpad.js
  • app/web/viewport.js
  • app/web/volume.js

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:38
    this._address = new PopupMenu.PopupMenuItem('', {reactive: false})
  • extension.js:50
    this._remember = new PopupMenu.PopupSwitchMenuItem(`Remember this browser for ${trustDurationDays(this._settings)} days`, false)
  • extension.js:34
    this._status = new PopupMenu.PopupMenuItem('Remote control is off', {reactive: false})

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:216
            notification.connect('destroy', () => {
                if (this._notification === notification)
                    this._notification = null;
            })

All Versions

Version Status
0.10.0 (3) Unreviewed
0.9.0 (2) Rejected
0.6.0 (1) Rejected

Previous Reviews on this Version

Javier Fernández Aparicio auto- rejected
Auto-rejected because of new version 0.9.0 (2) was uploaded