Review of "Stage Manager" version 1

Details Page Preview

Focus on one window at a time with a workspace-local strip of recent stages. Primary monitor only. Experimental, personal-use extension.

Extension Homepage
https://github.com/phucvinh57/gnome-stage-manager

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 2

Shexli found 3 issues that may need reviewer attention.

EGO-C49-004 error

extensions targeting GNOME 49 must not call Meta.Window.get_maximized

This extension explicitly targets GNOME Shell 49 but still calls removed `Meta.Window.get_maximized()`.

Meta.Window

  • src/shellCompat.js:3
    window.get_maximized()

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:80
            this._toggleItem = new PopupMenu.PopupSwitchMenuItem(
                'Stage Manager', this._settings.get_boolean('stage-enabled'))

EGO-M-008 warning

extensions using unlock-dialog must document it in disable() comments

Extensions using `unlock-dialog` should document the reason in `disable()` comments.

Session Modes

  • extension.js:44
        disable() {
            for (const name of this._bindings ?? [])
                Main.wm.removeKeybinding(name);
            this._bindings = null;
            if (this._sessionId) {
                Main.sessionMode.disconnect(this._sessionId);
                this._sessionId = 0;
            }
            if (this._settingsId

All Versions

Version Status
0.1.1 (3) Unreviewed
0.1.0 (2) Rejected
1 Rejected

Previous Reviews on this Version

phucvinh57 auto- rejected
Auto-rejected because of new version 0.1.0 (2) was uploaded