EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

• lib/images.js:99

  this.imageFile(hash).load_bytes(null)

• lib/storage.js:36

  this.file.load_contents(null)

EGO-X-003 warning

extensions should not call run_dispose in extension code

Extension code should not call `run_dispose()`.

GObject.Object.run_dispose

• shell/paster.js:51

  this._device.run_dispose()

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

• extension.js:354

          this._dialog.connect('destroy', () => {
              this._dialog = null;
          })

• extension.js:369

          this._dialog.connect('destroy', () => {
              this._dialog = null;
          })

• extension.js:522

              this._indicator.menu.connect('open-state-changed', (_menu, open) => {
                  if (!open && this._indicatorDirty)
                      this._renderIndicator();
              })

• extension.js:180

          this._snippetsMonitor.connect('changed', (_monitor, file, otherFile) => {
              const name = this._snippetsFile.file.get_basename();
              if (file?.get_basename() !== name && otherFile?.get_basename() !== name)
                  return;
              if (this._snippetsReloadId)
      

• extension.js:541

  menu.actor.connect('key-press-event', (_actor, event) => this._onMenuKey(menu, event))

• extension.js:542

          menu.connect('open-state-changed', (_menu, open) => {
              if (open)
                  this._focusMenuStart(menu);
              else
                  this._preview.hide();
          })