Review of "Todav: Tasks & Calendar" version 2.0.2 (2)

Details Page Preview

Companion extension for Todav, a task list and calendar app for GNOME that keeps your tasks and events in your Nextcloud through CalDAV. Shows a task list, the month with colored dots and the coming agenda in the top bar, or in the clock menu in place of GNOME's calendar and events; clicking an item opens it in Todav. Requires the Todav app (https://github.com/AperteDev/todav), whose Preferences hold the extension's options.

Extension Homepage
https://github.com/AperteDev/todav

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:283
            item.connect('clicked', () => {
                this._choosing = false;
                this._proxy.SetSettingAsync('ext_list', href)
                    .then(() => this._rebuild())
                    .catch(e => logError(e, 'Todav: cannot pick the list'));
            })
  • extension.js:323
    item.connect('clicked', () => this._open(p => p.ShowTaskAsync(uid)))
  • extension.js:386
    item.connect('clicked', () => this._open(p => p.ShowDayAsync(day)))
  • extension.js:118
            this.menu.connect('open-state-changed', (_menu, open) => {
                if (open) {
                    this._choosing = false;
                    this._month = null;
                    this._rebuild();
                }
            })

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • extension.js:183
            GLib.timeout_add_seconds(GLib.PRIORITY_DEFAULT, 3, () => {
                global.display.disconnect(id);
                return GLib.SOURCE_REMOVE;
            })

All Versions

Version Status
2.5.0 (4) Unreviewed
2.3.0 (3) Rejected
2.0.2 (2) Rejected
1.2.1 (1) Rejected

Previous Reviews on this Version

SelfRef auto- rejected
Auto-rejected because of new version 2.3.0 (3) was uploaded