Review of "Minie Pill" version 1

Details Page Preview

Dynamic-island style pill for GNOME Shell: clock, music + lyrics, timer, notifications, Bluetooth, Wi-Fi, DND, OSD, plus an expandable panel (calendar, weather, apps, clipboard, file shelf, controls).

Extension Homepage
https://github.com/yourtoxic/minie-pill

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 4 manual_review 3

Shexli found 7 issues that may need reviewer attention.

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 8 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • lib/controller.js:548
    console.log(`minie-pill: bluetooth connected: ${sel.name} icon=${sel.icon} kind=${BluetoothService.kindOf(sel)} battery=${sel.battery}`)
  • lib/controller.js:150
    console.warn(`minie-pill: service ${name} unavailable: ${e.message}`)
  • lib/controller.js:305
    console.warn(`minie-pill: feature ${name} failed: ${e.message}`)
  • lib/controller.js:311
    console.warn(`minie-pill: stopping ${name} failed: ${e.message}`)
  • lib/controller.js:495
    console.warn(`minie-pill: lyrics failed: ${e.message}`)
  • lib/controller.js:647
    console.warn(`minie-pill: weather failed: ${e.message}`)
  • lib/controller.js:674
    console.warn(`minie-pill: notification activate failed: ${e.message}`)
  • lib/controller.js:860
    console.warn(`minie-pill: cannot open download: ${e.message}`)

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • lib/services/clipboard.js:40
    St.Clipboard.get_default()
  • lib/services/clipboard.js:70
    St.Clipboard.get_default()
  • lib/services/shelf.js:26
    St.Clipboard.get_default()
  • lib/services/shelf.js:52
    St.Clipboard.get_default()

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • lib/services/downloads.js:165
    GLib.file_get_contents('/proc/net/dev')
  • lib/services/system.js:248
    GLib.file_get_contents(path)

EGO-A-001 manual_review

extension code must not be minified or obfuscated

File appears obfuscated: 60% of identifiers are 1–2 characters (avg length 3.7).

Code must not be obfuscated

  • lib/services/network.js
    short identifier ratio: 60%, identifiers scored: 77

EGO-A-001 manual_review

extension code must not be minified or obfuscated

File appears obfuscated: 65% of identifiers are 1–2 characters (avg length 3.2).

Code must not be obfuscated

  • lib/squircle.js
    short identifier ratio: 65%, identifiers scored: 226

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Package contains files that often should not be shipped for review.

Don't include unnecessary files

  • install.sh
    install.sh

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

All Versions

Version Status
1 Unreviewed