EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

• BWClipboard.js:21

  file.load_contents(null)

• utils.js:505

  file.load_contents(null)

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

• extension.js:298

  this.clipboardImageItem.connect('activate', this._copyImageToClipboard.bind(this))

• extension.js:299

  this.clipboardURLItem.connect('activate', this._copyURLToClipboard.bind(this))

• extension.js:254

  this.dwallpaperItem.connect('activate', this._setBackgroundDesktop.bind(this))

• extension.js:296

  this.folderItem.connect('activate', Utils.openImageFolder.bind(this, this._settings))

• extension.js:253

  this.openImageInfoLinkItem.connect('activate', this._openImageInfoLink.bind(this))

• extension.js:251

  this.openImageItem.connect('activate', this._openInSystemViewer.bind(this))

• extension.js:255

  this.refreshItem.connect('activate', () => this._refresh(true))

• extension.js:256

  this.settingsItem.connect('activate', this._openPrefs.bind(this))

• extension.js:798

  source.connect('destroy', () => this._notificationSources.delete(source))

• extension.js:250

  this.thumbnailItem.connect('activate', this._setBackgroundDesktop.bind(this))

• extension.js:284

          this.toggleImageCount.connect('toggled', (item, state) => {
              this._settings.set_boolean('show-count-in-image-title', state);
              this._selectImage(false);
          })

• extension.js:281

          this.toggleNotifications.connect('toggled', (item, state) => {
              this._settings.set_boolean('notify', state);
          })

• extension.js:278

          this.toggleSelectNew.connect('toggled', (item, state) => {
              this._settings.set_boolean('revert-to-current-image', state);
          })

• extension.js:275

          this.toggleSetBackground.connect('toggled', (item, state) => {
              this._settings.set_boolean('set-background', state);
          })

• extension.js:294

  this.toggleShuffle.connect('toggled', this._toggleShuffle.bind(this))

• extension.js:288

          this.toggleShuffleOnlyFaves.connect('toggled', (item, state) => {
              this._settings.set_boolean('random-mode-include-only-favourites', state);
          })