Review of "GitLab Tasks" version 1

Details Page Preview

Consulta tus tareas de GitLab y recibe avisos de asignaciones y deploys.

Extension Homepage
https://github.com/jpupo91/gitlab-tasks

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 4

Shexli found 4 issues that may need reviewer attention.

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 6 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • extension.js:274
    console.error(`[${this.uuid}] No se pudieron consultar los deploys de ${project.name_with_namespace}: ${error.message}`)
  • extension.js:329
    console.error(`[${this.uuid}] No se pudieron consultar los jobs del pipeline ${pipeline.pipelineId}: ${error.message}`)
  • extension.js:342
    console.error(`[${this.uuid}] No se pudieron actualizar los datos de GitLab: ${error.message}`)
  • extension.js:385
    console.error(`[${this.uuid}] No se pudieron consultar los colores de etiquetas del proyecto ${projectId}: ${error.message}`)
  • extension.js:438
    console.error(`[${this.uuid}] No se pudo ${verb} el job ${job.id}: ${error.message}`)
  • extension.js:1061
    console.error(`[${this.uuid}] No se pudo abrir el deploy en GitLab: ${error.message}`)

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:582
                this._dataContentScroll = new St.ScrollView({
                    overlay_scrollbars: false,
                    x_expand: true,
                    y_expand: true,
                })
  • extension.js:573
                this._dataFilterScroll = new St.ScrollView({
                    overlay_scrollbars: false,
                    x_expand: true,
                })

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:582
                this._dataContentScroll = new St.ScrollView({
                    overlay_scrollbars: false,
                    x_expand: true,
                    y_expand: true,
                })
  • extension.js:573
                this._dataFilterScroll = new St.ScrollView({
                    overlay_scrollbars: false,
                    x_expand: true,
                })

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:607
                dialog.connect('closed', () => {
                    if (this._dataDialog !== dialog)
                        return;
                    this._dataDialogClosing = true;
                    this._dataTabBar = null;
                    this._dataFilterScroll = null;
                    this._dataFilterBar = null

All Versions

Version Status
1 Unreviewed