Review of "Links GNOME" version 2

Details Page Preview

Abre enlaces con una aplicación elegida según su URL.

Extension Homepage
https://github.com/jpupo91/links-gnome

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-L-006 warning

preferences classes should not retain window-scoped objects on instance fields without close-request cleanup

Preferences code stores window-scoped objects on the exported prefs class without `close-request` cleanup.

Destroy all objects

  • prefs.js:8
    this._settings = this.getSettings()
  • prefs.js:19
            this._rulesBox = new Gtk.Box({
                orientation: Gtk.Orientation.VERTICAL,
                spacing: 8,
            })
  • prefs.js:52
            this._fallbackEntry = new Gtk.Entry({
                text: this._settings.get_string('fallback-app'),
                placeholder_text: 'Vacío = aplicación predeterminada',
                hexpand: true,
                valign: Gtk.Align.CENTER,
            })
  • prefs.js:114
    this._ruleRows = this._ruleRows.filter(item => item !== ruleRow)

All Versions

Version Status
2 Unreviewed
1 Rejected