Review of "Novus DayNight" version 1

Details Page Preview

Automatically switches GTK themes, color scheme, wallpapers, Night Light, and display brightness based on local sunrise/sunset times or a custom schedule. Optional location auto-detection uses GeoClue2 with fallback to ipinfo.io and nominatim.openstreetmap.org. Based on Automatic Theme Switcher by Amritashan S. Lal.

Extension Homepage
https://github.com/SGC-NOVUS/novus-daynight

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 10 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • themeController.js:49
    console.log(`NovusDayNight: Night Light ${isDark ? 'enabled' : 'disabled'} (synced with theme)`)
  • themeController.js:58
    console.log(`NovusDayNight: Switched to ${isDark ? 'Dark' : 'Light'} theme (${theme}), color-scheme: ${colorScheme}, True Light Mode: ${trueLightMode ? 'enabled' : 'disabled'}`)
  • themeController.js:92
    console.log(`NovusDayNight: Applied dual wallpapers (light: ${lightUri}, dark: ${darkUri})`)
  • themeController.js:102
    console.log(`NovusDayNight: Wallpaper updated for ${isDark ? 'dark' : 'light'} mode: ${formattedUri}`)
  • themeController.js:139
    console.log(`NovusDayNight: Custom hook finished: ${cmd}`)
  • themeController.js:165
    console.log(`ThemeSwitcher: Night Light custom schedule set: ${startTime} to ${endTime}`)
  • themeController.js:141
    console.warn(`NovusDayNight: Custom hook returned error: ${e.message}`)
  • themeController.js:106
    console.error(`NovusDayNight: Failed to update wallpaper: ${e.message}`)
  • themeController.js:145
    console.error(`NovusDayNight: Failed to launch hook: ${e.message}`)
  • themeController.js:167
    console.error('ThemeSwitcher: Invalid Night Light schedule times')

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

All Versions

Version Status
2 Unreviewed
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
This code seems to be generated by AI. Please note, we have a rule for that: - [EGO Review Guidelines: AI](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#extensions-must-not-be-ai-generated) - [Extensions Best Practices Guidelines](https://gjs.guide/extensions/review-guidelines/best-practices.html#submissions-require-maintainership) Also you should use d-bus not spawn commands.