Review of "Scale By Display" version 9

Details Page Preview

Extension which tweaks your font scaling and other settings based on display configuration

Extension Homepage
https://github.com/ilya-m32/scale-by-display

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:26
    this.#connections.connect(Main.sessionMode, "updated", onUpdate)
  • extension.js:27
    this.#connections.connect(this.#settings, "changed", onUpdate)
  • extension.js:28
    this.#connections.connect(this.#profileManager, "updated", onUpdate)
  • profile.js:50
    this.#connections.connect(this.#settings, "changed", onUpdate)
  • profile.js:51
    this.#connections.connect(this.#monitorsConfig, "updated", onUpdate)

All Versions

Version Status
9 Active
8 Active
7 Active
6 Active
5 Active
4 Active
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

ilya-m64 posted a review
I have addressed the issues flagged by the auto review from the last time. However, EGO-L-003 is a false positive, as I have implemented a custom class for automatic connection on extension disable() hook.
JustPerfection active