Review "Now Pill" version 1 (1) - GNOME Shell Extensions

Review of "Now Pill" version 1 (1)

Details Page Preview

Now Pill

A Samsung-style Now Bar for the top bar: one pill shows what is going on right now (music, a timer, a screen recording, the camera in use, charging, the weather...). Scroll over it to switch between activities, click it for the details and controls. A screenshot's card can copy the image to the clipboard (only when its Copy button is clicked).

Extension Homepage: https://github.com/vinicgobbi/gnome-extension-nowpill

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2 manual_review 1

Shexli found 3 issues that may need reviewer attention.

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

lib/sources/capture.js:107
```
St.Clipboard.get_default()
```

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

lib/ui/widgets.js:414

this._timeline = new Clutter.Timeline({actor, duration: 1000, repeat_count: -1})

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

lib/ui/widgets.js:417

actor.connect('destroy', () => this.destroy())

All Versions

Version	Status
1 (1)	Unreviewed