Review of "Dash2Dock Motion" version 3

Details Page Preview

Dock with cosine-window icon magnification, a translucent glass slab and configurable rise.

Extension Homepage
https://github.com/Unmade760/dash2dock-motion

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-P-007 warning

JavaScript files should be reachable from extension.js or prefs.js

Some JavaScript files are not reachable from `extension.js` or `prefs.js` imports.

Don't include unnecessary files

  • locationsWorker.js

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • docking.js:295
    this.staticBox = new Clutter.ActorBox()

All Versions

Version Status
4 Unreviewed
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

unmade auto- rejected
Auto-rejected because of new version 4 was uploaded