Review of "evcc Top Bar" version 1

Details Page Preview

Shows selected evcc values in the top bar and opens the evcc web app. The web-app window requires WebKitGTK 6.0.

Extension Homepage
https://github.com/gremmlinMTW/evcc-gnome-shell

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-P-007 warning

JavaScript files should be reachable from extension.js or prefs.js

Some JavaScript files are not reachable from `extension.js` or `prefs.js` imports.

Don't include unnecessary files

  • webapp.js

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:220
            window.connect('unmanaged', () => {
                if (titleSignalId)
                    window.disconnect(titleSignalId);
                if (this._webappWindow === window)
                    this._webappWindow = null;
            })

All Versions

Version Status
0.0.5 (2) Unreviewed
1 Rejected

Previous Reviews on this Version

gremmlinMTW auto- rejected
Auto-rejected because of new version 0.0.5 (2) was uploaded