Review of "Anahita Wallpaper Changer" version 1

Details Page Preview

Automatically change desktop wallpapers right from your top bar. Connects to popular online providers (Unsplash, Wallhaven, Bing) or local picture folders, featuring one-click Next/Previous controls, dynamic categories, and independent multi-monitor displays.

Extension Homepage
https://github.com/ibehii/Wallpaper-changer

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • extension.js:217
    file.load_contents(null)

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:637
            this._useLocalSourceSwitch.connect('toggled', (item, state) => {
                this._setStringSetting('wallpaper-source', state ? 'local' : 'online');
                if (state) {
                    this._ensureRotatorEnabled();
                }
            })
  • extension.js:1002
            this.menu.connect('open-state-changed', (menu, isOpen) => {
                if (isOpen) {
                    this._updateNavButtons();
                }
            })
  • extension.js:656
            localSubMenu.menu.connect('open-state-changed', (menu, isOpen) => {
                if (isOpen) {
                    const localDir = this._getLocalPhotosDirectory();
                    const recursive = this._getBooleanSetting('recursive-scan', true);
                    const photos = getLocalPhotos(loc
  • extension.js:759
            sourcesSubMenu.menu.connect('open-state-changed', (menu, isOpen) => {
                if (isOpen) {
                    updateProviderMenuOrnaments();
                }
            })

All Versions

Version Status
2 Unreviewed
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
This code seems to be generated by AI. Please note, we have a rule for that: - [EGO Review Guidelines: AI](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#extensions-must-not-be-ai-generated) - [Extensions Best Practices Guidelines](https://gjs.guide/extensions/review-guidelines/best-practices.html)