Review of "Cliporium" version 2

Details Page Preview

A local clipboard history for GNOME Shell. Cliporium reads clipboard text and images to store recent items on this device, never sends them anywhere, and lets you search, pin, and restore them from a keyboard-first popup.

Extension Homepage
https://github.com/engida32/cliporium

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1 manual_review 1

Shexli found 2 issues that may need reviewer attention.

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • extension.js:54
    St.Clipboard.get_default()

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • extension.js:789
                this._captureTimeout = GLib.timeout_add(GLib.PRIORITY_DEFAULT, 150, () => {
                    this._captureTimeout = 0;
                    this._captureClipboard().catch(() => {});
                    return GLib.SOURCE_REMOVE;
                })
  • extension.js:642
            this._focusTimeout = GLib.timeout_add(GLib.PRIORITY_DEFAULT, 50, () => {
                this._focusTimeout = 0;
                if (!this._destroyed)
                    global.stage.set_key_focus(this._search);
                return GLib.SOURCE_REMOVE;
            })
  • extension.js:1672
                this._noticeTimeout = GLib.timeout_add(
                    GLib.PRIORITY_DEFAULT,
                    timeout,
                    () => {
                        this._noticeTimeout = 0;
                        this._noticeText = '';
                        this._noticeWarning = false;
                        thi
  • extension.js:1433
            this._previewFocusTimeout = GLib.idle_add(GLib.PRIORITY_DEFAULT, () => {
                this._previewFocusTimeout = 0;
                if (!this._destroyed && this._previewId)
                    this._previewBack.grab_key_focus();
                return GLib.SOURCE_REMOVE;
            })
  • extension.js:983
            this._searchTimeout = GLib.timeout_add(GLib.PRIORITY_DEFAULT, 120, () => {
                this._searchTimeout = 0;
                this._refresh();
                return GLib.SOURCE_REMOVE;
            })

All Versions

Version Status
3 Unreviewed
2 Rejected
1 Rejected

Previous Reviews on this Version

engida auto- rejected
Auto-rejected because of new version 3 was uploaded