Review of "Radiola" version 1.3 (1)

Details Page Preview

Listen to internet radio from the top bar. Search more than 50,000 stations worldwide (radio-browser.info), keep your favorites, see the song that is playing and control playback with the media keys or any media control. Playback keeps going while the screen is locked; the panel menu is hidden on the lock screen. A button in the menu copies the song title to the clipboard.

Extension Homepage
https://github.com/Aleixenandros/radiola

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1 manual_review 1

Shexli found 2 issues that may need reviewer attention.

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • lib/indicator.js:131
    St.Clipboard.get_default()

EGO-P-007 warning

JavaScript files should be reachable from extension.js or prefs.js

Some JavaScript files are not reachable from `extension.js` or `prefs.js` imports.

Don't include unnecessary files

  • lib/playerHelper.js

All Versions

Version Status
1.5 (3) Active
1.4 (2) Rejected
1.3 (1) Rejected

Previous Reviews on this Version

JustPerfection rejected
Didn't review. This code seems to be generated by AI. Please note, we have a rule for that: - [EGO Review Guidelines: AI](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#extensions-must-not-be-ai-generated) - [Extensions Best Practices Guidelines](https://gjs.guide/extensions/review-guidelines/best-practices.html) Also `Gst.init` can crash shell if you don't check with `is_initialized`.
Aleixenandros_ posted a review
Changes since 1.3: Gst.init() is now guarded with Gst.is_initialized(). GStreamer is never loaded inside GNOME Shell: lib/playerHelper.js runs as a separate gjs process started by lib/player.js, which is why Shexli reports it as unreachable. Loading Gst in the shell froze the session at login. The clipboard is only written when the user clicks the copy button, as stated in the description. About AI: I wrote this extension with the help of IA. I have reviewed the code and can explain any part of it.