Review of "Lid Switch" version 1

Details Page Preview

Toggle laptop lid-close behavior between sleep and active

Extension Homepage
https://github.com/dhyandevp/lid-switch

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 3

Shexli found 4 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • extension.js:76
    GLib.file_get_contents(path)

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 6 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • extension.js:62
    console.error(`LidSwitch: failed to save lock state: ${e.message}`)
  • extension.js:87
    console.error(`LidSwitch: failed to restore lock state: ${e.message}`)
  • extension.js:101
    console.error(`LidSwitch: failed to set power action: ${e.message}`)
  • extension.js:118
    console.error(`LidSwitch: failed to disable lock: ${e.message}`)
  • extension.js:146
    console.error(`LidSwitch: Inhibit call failed: ${e.message}`)
  • extension.js:160
    console.error(`LidSwitch: error closing fd: ${e.message}`)

EGO-P-003 error

GSettings schema XML must be present in package

Extension appears to use GSettings but no `.gschema.xml` file is included in the package.

GSettings Schemas

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:36
            this._toggle.connect('clicked', () => {
                this._onToggleClicked();
            })

All Versions

Version Status
4 Active
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

dhyandevp posted a review
dhyandevp auto- rejected
Auto-rejected because of new version 2 was uploaded