Review of "Simple Pleasures" version 1.1.1 (3)

Details Page Preview

Tweak annoying defaults and enable quality of life features: a top bar application menu, window titles and buttons in the panel, hidden titlebars on maximized windows, and more. A fork of Essential Tweaks with window management features adapted from Unite Shell.

Extension Homepage
https://gitlab.gnome.org/somepaulo/simple-pleasures

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli did not find any issues.

All Versions

Version Status
1.1.8 (4) Active
1.1.1 (3) Rejected
1.1.0 (2) Rejected
1.0.0 (1) Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please use `connectObject()` and `disconnectObject()` so it is easier to track for cleanup. 2. Please remove unnecessary try-catch wrappers: [Extension Best Practices Guidelines: Unnecessary try-catch](https://gjs.guide/extensions/review-guidelines/best-practices.html#avoid-unnecessary-try-catch-wrappers) 3. Selective disable isn't allowed: - line 151-152 `lib/windowButtons.js` - line 47-48 `lib/noWindowReadyNotifications.js` - line 95-96 `lib/keepFavoritesInAppGrid.js` - line 196-197 `lib/appMenu.js` 4. `this._enabled` is a bad practice. Please remove that: [Extension Best Practices Guidelines: Lifecycle and Destruction State](https://gjs.guide/extensions/review-guidelines/best-practices.html#lifecycle-and-destruction-state) 5. Not connected (line 130 `lib/appMenu.js`). Better to rename to `destroy()` and do `super.destroy()` at the end of that function. 6. Please hard code `executable` (line 227 `lib/hideTitlebars.js`). We need to trace back through many steps to find out what the value is, and we could miss the changed value in future diffs.